• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This removes the MachineConfigNodes and PinnedImages feature gates and should merge after openshift/machine-config-operator#5609.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Walkthrough

This pull request removes two feature gates—MachineConfigNodes and PinnedImages—from the codebase. The removal includes deleting the feature gate definitions from the Go code, removing them from multiple feature gate manifest files across different platform configurations, and deleting feature gate annotations from API type definitions. Additionally, the v1alpha1 API definitions for MachineConfigNode and PinnedImageSet are deleted entirely, along with their test files and registration entries. Feature gate references are also cleaned up from CRD test manifests and generated manifests.

❌ Failed checks (1 warning)

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• Generate coding plan for human review comments

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

• Remove MachineConfigNodes feature gate definition and references
• Remove PinnedImages feature gate definition and references
• Update feature gate manifest files across all cluster profiles
• Fix indentation inconsistencies in feature gate definitions

Remove two feature gate definitions and fix indentation

features/features.go

Remove feature gate rows from documentation table

features.md

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Description

MachineConfigNodes is removed from the rendered FeatureGate enabled list, but MachineConfigNode
CRDs/types are still annotated as gated on MachineConfigNodes, so manifest-merge will exclude
those manifests for every FeatureSet/profile. This will change generated CRD outputs (and likely
fail verify-codegen-crds) and can drop MachineConfigNode gated content from rendered payloads.

Code

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[L316-318]

-                    {
-                        "name": "MachineConfigNodes"
-                    },

Evidence

The payload FeatureGate manifest no longer lists MachineConfigNodes as enabled, while the CRD/type
inputs remain annotated with feature-gate.release.openshift.io/MachineConfigNodes. The
manifest-merge filter explicitly includes gated manifests only when all their
feature-gate.release.openshift.io/* annotations are present in the enabled set read from the
payload FeatureGate YAML; verify-codegen-crds runs this generator in verify mode.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[313-342]
machineconfiguration/v1alpha1/types_machineconfignode.go[10-20]
machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml[4-13]
tools/codegen/pkg/manifestmerge/filters.go[440-475]
tools/codegen/pkg/manifestmerge/filters.go[509-522]
hack/verify-codegen-crds.sh[5-7]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`MachineConfigNodes` was removed from the payload FeatureGate enabled lists, but some CRDs/types are still marked with `+openshift:enable:FeatureGate=MachineConfigNodes` and generated partial manifests still carry `feature-gate.release.openshift.io/MachineConfigNodes`. The manifest-merge generator filters gated manifests by the enabled feature gates from payload FeatureGate YAMLs, so these inputs become unselectable and will change generated outputs / fail `--verify`.

### Issue Context
The intent of this PR is to remove the feature gate entirely (i.e., feature becomes unconditional). That requires removing the API/CRD gating markers as well and regenerating the derived manifests.

### Fix Focus Areas
- machineconfiguration/v1alpha1/types_machineconfignode.go[10-20]
- machineconfiguration/v1/types_machineconfignode.go[10-20]
- machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml[4-13]
- tools/codegen/pkg/manifestmerge/filters.go[440-475]

After removing the gating markers, run the repo’s CRD codegen update (the same generators used by `hack/verify-codegen-crds.sh`) and commit the updated generated outputs (including any featuregated test cases that still mention `MachineConfigNodes`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

PinnedImages is removed from the rendered FeatureGate enabled list, but several APIs/CRD partial
manifests are still gated on PinnedImages, so manifest-merge will exclude those manifests for
every FeatureSet/profile. This will change generated CRD outputs (and likely fail
verify-codegen-crds) and can drop pinned-images related schema/CRDs from rendered payloads.

Code

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[L340-342]

-                    {
-                        "name": "PinnedImages"
-                    },

Evidence

The payload FeatureGate manifest no longer lists PinnedImages as enabled, but the pinned-images
APIs and CRD partials still include +openshift:enable:FeatureGate=PinnedImages and
feature-gate.release.openshift.io/PinnedImages. The manifest-merge filter includes a manifest only
if its feature-gate.release.openshift.io/* annotations are all present in the enabled set loaded
from the payload FeatureGate YAML.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[331-342]
machineconfiguration/v1alpha1/types_pinnedimageset.go[10-20]
machineconfiguration/v1/types.go[440-455]
machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/pinnedimagesets.machineconfiguration.openshift.io/PinnedImages.yaml[4-13]
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/PinnedImages.yaml[4-12]
tools/codegen/pkg/manifestmerge/filters.go[509-522]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The `PinnedImages` feature gate was removed from the payload FeatureGate enabled lists, but several APIs/CRD partial manifests are still gated on `PinnedImages` via `+openshift:enable:FeatureGate=PinnedImages` and `feature-gate.release.openshift.io/PinnedImages`. The manifest-merge generator filters gated manifests by the enabled feature gates from payload FeatureGate YAMLs, so these manifests become unselectable and will change generated outputs / fail `--verify`.

### Issue Context
If `PinnedImages` is intended to be always-on, remove the gating markers and regenerate the CRD outputs so the schema/CRDs are no longer conditioned on a non-existent feature gate.

### Fix Focus Areas
- machineconfiguration/v1alpha1/types_pinnedimageset.go[10-20]
- machineconfiguration/v1/types.go[440-548]
- machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/pinnedimagesets.machineconfiguration.openshift.io/PinnedImages.yaml[4-13]
- machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/PinnedImages.yaml[4-12]
- tools/codegen/pkg/manifestmerge/filters.go[440-475]

After removing the gating markers, run the CRD generators invoked by `hack/verify-codegen-crds.sh` and commit updated generated files (including any featuregated tests that still list `PinnedImages`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This removes the MachineConfigNodes and PinnedImages feature gates as well as the v1alpha1 APIs for each, which were replaces with v1 APIs in 4.19 (#2255 & #2198).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.